Loki #1826
Merged
Loki #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids an issue where we clear the logs buffer before the loki write path has a chance to consume/transform it Change-type: patch
Change-type: patch
otaviojacobi
approved these changes
Oct 30, 2024
thgreasi
previously approved these changes
Oct 30, 2024
| @@ -132,6 +132,8 @@ function handleStoreErrors(req: Request, res: Response, err: Error) { | |||
| res.status(500).end(); | |||
| } | |||
|
|
|||
| const lokiBackend = LOKI_ENABLED ? await getLokiBackend() : undefined; | |||
There was a problem hiding this comment.
I hope the top level await would not cause any unexpected issues 😬
policy-bot-palantir-policy-bot
bot
dismissed
thgreasi’s stale review
Comment was edited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.